Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Postgres and AWS instances #55

Merged
merged 2 commits into from
Feb 3, 2020
Merged

Conversation

tammersaleh
Copy link

@tammersaleh tammersaleh commented Feb 3, 2020

AWS no longer allows provisioning Postgres v9.4, and they deprecated the
m3 instance family.

This commit also fixes the development smoke tests, which were
missing the aws-db-test repo.

Security Considerations

While fixing this, we also move the non-CUI information from the secrets
variables into inline pipeline.yml values. Putting DB versions and other
non-CUI information in the variables files means we have to treat them
as secrets, and means we don't get all of the git-nicities when
modifying them.

AWS no longer allows provisioning Postgres v9.4, and they deprecated the
m3 instance family.

While fixing this, we also move the non CUI information from the secrets
variables into inline pipeline.yml values. Putting DB versions and other
non-CUI information in the variables files means we have to treat them
as secrets, and means we don't get all of the git-nicities when
modifying them.

Finally, this commit fixes the development smoke tests, which were
missing the `aws-db-test` repo.
@tammersaleh
Copy link
Author

tammersaleh commented Feb 3, 2020

This PR has already been run through our pipeline, but we haven't merged into master.

This resolves cloud-gov/product#1187

@tammersaleh tammersaleh marked this pull request as ready for review February 3, 2020 18:13
bengerman13
bengerman13 previously approved these changes Feb 3, 2020
ci/pipeline.yml Show resolved Hide resolved
@bengerman13
Copy link
Contributor

Looks like your PR needs a Security Considerations section

This is more consistent with our other pipelines.
@bengerman13 bengerman13 merged commit 501b338 into master Feb 3, 2020
@tammersaleh tammersaleh deleted the tsaleh/fix-pipeline branch February 4, 2020 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants